Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2239#discussion_r184842333
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/store/SparkCarbonStore.scala
---
@@ -110,8 +110,16 @@ class SparkCarbonStore extends MetaCachedCarbonStore {
}
def startSearchMode(): Unit = {
+ LOG.info("Search mode master start service")
master = new Master(session.sparkContext.getConf)
master.startService()
+ var count = 0
+ while (!master.isStarted()) {
+ Thread.sleep(10)
--- End diff --
Is 10ms a proper period?
What if there is a situation that the master starts too late or failed and
there will be a log explosion.
So better to add a maximum retrying counts or time and make the sleeping
time dynamic by double it.
---
