Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2209#discussion_r184917833
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/complextypes/PrimitiveQueryType.java
---
@@ -108,4 +128,14 @@ public PrimitiveQueryType(String name, String
parentname, int blockIndex,
}
return actualData;
}
+
+ @Override public Object
getDataBasedOnDataTypeFromNoDictionary(ByteBuffer data) {
--- End diff --
I don't think it is required to have one more method, just rename and
handle in same method `getDataBasedOnDataTypeFromSurrogates` , it can avoid
duplicate code and extra handling
---
