Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2209#discussion_r184919308
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java
 ---
    @@ -245,6 +312,28 @@ public void parseAndBitPack(ByteBuffer byteArrayInput, 
DataOutputStream dataOutp
         dataOutputStream.write(v);
       }
     
    +  @Override
    +  public int parseComplexValue(ByteBuffer byteArrayInput, DataOutputStream 
dataOutputStream,
    +      KeyGenerator[] generator, Boolean[][] 
complexDictionaryIndentification, int startOffset)
    +      throws IOException, KeyGenException {
    +    if (!this.isDictionary) {
    +      int sizeOfData = byteArrayInput.getInt();
    +      startOffset += Integer.SIZE / Byte.SIZE;
    +      dataOutputStream.writeInt(sizeOfData);
    +      byte[] bb = new byte[sizeOfData];
    +      byteArrayInput.get(bb, 0, sizeOfData);
    +      dataOutputStream.write(bb);
    +      startOffset += sizeOfData;
    +    } else {
    +      int data = byteArrayInput.getInt();
    +      startOffset += Integer.SIZE / Byte.SIZE;
    --- End diff --
    
    I think this is not required, if it is only writeoffset


---

Reply via email to