Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2209#discussion_r184963740
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/datatypes/GenericDataType.java
 ---
    @@ -80,7 +82,13 @@ void writeByteArray(T input, DataOutputStream 
dataOutputStream)
        * @throws KeyGenException
        */
       void parseAndBitPack(ByteBuffer byteArrayInput, DataOutputStream 
dataOutputStream,
    -      KeyGenerator[] generator) throws IOException, KeyGenException;
    +      KeyGenerator[] generator)
    +      throws IOException, KeyGenException;
    +
    +
    +  int parseComplexValue(ByteBuffer byteArrayInput, DataOutputStream 
dataOutputStream,
    +      KeyGenerator[] generator, Boolean[][] 
complexDictionaryIndentification, int startOffset)
    +      throws IOException, KeyGenException;
    --- End diff --
    
    complexDictionaryIndentification is removed but StartOffset is used. 


---

Reply via email to