Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2254#discussion_r185233625
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -986,4 +990,26 @@ public boolean canAllow(CarbonTable carbonTable,
TableOperation operation) {
return true;
}
+ /**
+ * Get all index columns specified by dataMapSchema
+ */
+ public List<CarbonColumn> getIndexedColumns(DataMapSchema dataMapSchema)
--- End diff --
I think it's better to use `columnNames` as the input parameter rather than
`dataMapSchema`.
The method in CarbonTable class does not need to know more information than
`columnNames` from `dataMapSchema`, so better to pass less information.
---
