GitHub user praveenmeenakshi56 opened a pull request:

    https://github.com/apache/carbondata/pull/2259

    [CARBONDATA-2426] Added fix for data mismatch after compaction on Partition 
with Pre-Aggregate tables

    **Problem:**  Partition directory is getting deleted when one on the 
segment is marked for delete and another segment is loaded in the same 
partition.
    In case of aggregate table we only have partition specs for the specified 
segments therefore when the deleted segment is scanned against locationMap for 
stale partitions one of the valid partition is considered as stale as we dont 
get partitionSpecs for all the segments. 
    
    **Solution:** Delete the index file instead of the partition directory and 
then delete the directory if it is empty.
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests 
are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance 
test report.
            - Any additional information to help reviewers in testing this 
change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/praveenmeenakshi56/carbondata fix_ioex

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2259.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2259
    
----
commit 46b4e7d5dc3efc17cc19fa576207d13537499970
Author: praveenmeenakshi56 <praveenmeenakshi56@...>
Date:   2018-05-02T10:09:28Z

    Added fix for data mismatch after compaction on Partition with 
Pre-Aggregate tables

----


---

Reply via email to