Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2239#discussion_r185680045
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/carbondata/store/SparkCarbonStore.scala
 ---
    @@ -110,8 +110,16 @@ class SparkCarbonStore extends MetaCachedCarbonStore {
       }
     
       def startSearchMode(): Unit = {
    +    LOG.info("Starting search mode master")
         master = new Master(session.sparkContext.getConf)
         master.startService()
    +    var count = 0
    +    while (master.isStarted().compareAndSet(false, false) && count < 5000) 
{
    --- End diff --
    
    I think you can move this while loop into master.startService, so that 
master.startService is a blocking operation until it is success.  No need to 
expose master.isStarted method


---

Reply via email to