Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2255#discussion_r186294094
--- Diff:
datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapFactoryBase.java
---
@@ -153,8 +153,8 @@ public DataMapWriter createWriter(Segment segment,
String shardName) {
}
@Override
- public DataMapRefresher createRefresher(Segment segment, String
shardName) {
- return new LuceneDataMapRefresher(getCarbonTable().getTablePath(),
dataMapName,
+ public DataMapBuilder createBuilder(Segment segment, String shardName) {
--- End diff --
A question that does not relate to this PR: what's the relationship between
a `segment` and a `shard`? (in traditional carbondata table storage and in
other table storage, such as external table/ hive-partition-like table...)
---
