GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2279

    [CARBONDATA-2454][DataMap] Add fpp property for bloom datamap

    add fpp(false positive probability) property to configure bloom filter
    that used by bloom datamap.
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [x] Any interfaces changed?
     `changed only internal used interfaces`
     - [x] Any backward compatibility impacted?
     `NO`
     - [x] Document update required?
    `NO`
     - [x] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests 
are required?
    `Tests will be added in the future`
            - How it is tested? Please attach test report.
    `tested in standalone 3-node cluster`
            - Is it a performance related change? Please attach the performance 
test report.
    `Yes, proper fpp can improve the query performance`
            - Any additional information to help reviewers in testing this 
change.
           `NA`
     - [x] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
    `NA`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0508_add_bloom_ffp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2279
    
----
commit 57d2e702cce739c709bba6e352366e1d0ba773c6
Author: xuchuanyin <xuchuanyin@...>
Date:   2018-05-08T04:00:39Z

    Add fpp property for bloom datamap
    
    add fpp(false positive probability) property to configure bloom filter
    that used by bloom datamap.

----


---

Reply via email to