Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2262#discussion_r187310523
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java
---
@@ -435,23 +436,30 @@ public TableSegmentRefresher
getTableSegmentRefresher(CarbonTable table) {
SegmentUpdateDetails[] updateStatusDetails =
statusManager.getUpdateStatusDetails();
for (SegmentUpdateDetails updateDetails : updateStatusDetails) {
UpdateVO updateVO =
statusManager.getInvalidTimestampRange(updateDetails.getSegmentName());
- segmentRefreshTime.put(updateVO.getSegmentId(),
updateVO.getCreatedOrUpdatedTimeStamp());
+ segmentRefreshTime.put(updateVO.getSegmentId(),
+ new
SegmentLatestTimestampUpdater(updateVO.getCreatedOrUpdatedTimeStamp(), 0));
}
}
- public boolean isRefreshNeeded(String segmentId,
SegmentUpdateStatusManager statusManager) {
- UpdateVO updateVO =
statusManager.getInvalidTimestampRange(segmentId);
+ public boolean isRefreshNeeded(Segment seg) throws IOException {
+ Map<String, SegmentLatestTimestampUpdater>
segmentTimestampUpdaterMap =
--- End diff --
No need to use Map here, jus store SegmentLatestTimestampUpdater is enough
---
