Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2294#discussion_r187337029
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java
---
@@ -114,12 +115,12 @@ public void setSortColumns(List<ColumnSchema>
sortColumns) {
this.sortColumns = sortColumns;
}
- public ColumnSchema addColumn(StructField field, boolean isSortColumn) {
- return addColumn(field, null, isSortColumn, false);
+ public ColumnSchema addColumn(StructField field, AtomicInteger valIndex,
boolean isSortColumn) {
--- End diff --
Do we need Atomic Integer ? This is single threaded. Later phase also even
if writer becomes multi threaded, building schema and CarbonTable should remain
single threaded only.
---
