GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2300
[CARBONDATA-2459][DataMap] Add cache for bloom filter datamap
Loading bloom filter from bloomindex file is slow. Adding cache for this
procedure will surely improve the query performance. In this commit, the cache
is implemented using guava cache instead of cache implemented by carbon. The
reason is that there will be a cyclic dependency between module carbon-core and
carbon-bloom if we use carbon cache in cabon-bloom.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`NO`
- [x] Any backward compatibility impacted?
`NO`
- [x] Document update required?
`NO`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
`No`
- How it is tested? Please attach test report.
`Tested in 3-node cluster.`
- Is it a performance related change? Please attach the performance
test report.
`Query performance is enhanced`
- Any additional information to help reviewers in testing this
change.
`NO`
- [x] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
`NA`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata 0511_cache_bloom_datamap
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2300.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2300
----
commit 0ecdcf909ac8d7fa2c59042130d554913124b9d1
Author: xuchuanyin <xuchuanyin@...>
Date: 2018-05-11T13:49:43Z
Add cache for bloom filter datamap
Loading bloom filter from bloomindex file is slow. Adding cache for this
procedure will surely improve the query performance. In this commit, the cache
is implemented using guava cache instead of cache implemented by carbon. The
reason is that there will be a cyclic dependency between module carbon-core and
carbon-bloom if we use carbon cache in cabon-bloom.
----
---
