Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2304#discussion_r188885431
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java
 ---
    @@ -353,6 +427,32 @@ public double getDouble(int rowId) {
         return data;
       }
     
    +  @Override public byte[] getComplexChildrenLVFlattenedBytePage() throws 
IOException {
    +    // output LV encoded byte array
    +    int offset = 0;
    +    byte[] data = new byte[totalLength + pageSize * 2];
    +    for (int rowId = 0; rowId < pageSize; rowId++) {
    +      short length = (short) (rowOffset[rowId + 1] - rowOffset[rowId]);
    +      ByteUtil.setShort(data, offset, length);
    +      copyBytes(rowId, data, offset + 2, length);
    +      offset += 2 + length;
    +    }
    +    return data;
    +  }
    +
    +  @Override
    +  public byte[] getComplexParentFlattenedBytePage() throws IOException {
    --- End diff --
    
    Check and remove if not required


---

Reply via email to