GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2318
[CARBONDATA-2491] Fix the error when reader read twice with SDK
carbonReader
[CARBONDATA-2491] Fix the error when reader read twice with SDK
carbonReader
1.Fix the error out of bound when reader read twice with SDK carbonReader
2.Fix the java.lang.NegativeArraySizeException
3.Add timestamp and bad record test case
This PR dependency on https://github.com/apache/carbondata/pull/2246
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
No
- [ ] Any backward compatibility impacted?
No
- [ ] Document update required?
No
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
No
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata
CARBONDATA-2491-OutOfBoundAndBadRecord
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2318.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2318
----
commit 8ae64ed8b3991753d2745f5e0e4a83b2bf970dd2
Author: xubo245 <xubo29@...>
Date: 2018-05-17T04:13:01Z
[CARBONDATA-2413] After running CarbonWriter, there is null directory
about datamap
if the segment id is null, then don't register all datamap writer
and don't create null directory
remove line
commit 19043b6579d98908b1f9052b8ae4de8c9881161e
Author: xubo245 <xubo29@...>
Date: 2018-05-18T07:40:16Z
[CARBONDATA-2491] Fix the error when reader read twice with SDK carbonReader
----
---
