Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2275#discussion_r189420060
--- Diff:
datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapFactoryBase.java
---
@@ -107,13 +138,39 @@ public LuceneDataMapFactoryBase(CarbonTable
carbonTable, DataMapSchema dataMapSc
// optimizedOperations.add(ExpressionType.LESSTHAN_EQUALTO);
// optimizedOperations.add(ExpressionType.NOT);
optimizedOperations.add(ExpressionType.TEXT_MATCH);
- this.dataMapMeta = new DataMapMeta(indexedColumns,
optimizedOperations);
-
+ this.dataMapMeta = new DataMapMeta(indexedCarbonColumns,
optimizedOperations);
// get analyzer
// TODO: how to get analyzer ?
analyzer = new StandardAnalyzer();
}
+ public static int validateAndGetWriteCacheSize(DataMapSchema schema) {
+ String cacheStr = schema.getProperties().get(FLUSH_CACHE);
+ if (cacheStr == null) {
+ cacheStr = FLUSH_CACHE_DEFAULT_SIZE;
+ }
+ int cacheSize;
+ try {
+ cacheSize = Integer.parseInt(cacheStr);
+ } catch (NumberFormatException e) {
+ cacheSize = -1;
+ }
+ return cacheSize;
+ }
+
+ public static boolean validateAndGetStoreBlockletWise(DataMapSchema
schema) {
+ String splitBlockletStr = schema.getProperties().get(SPLIT_BLOCKLET);
+ if (splitBlockletStr == null) {
+ splitBlockletStr = SPLIT_BLOCKLET_DEFAULT;
+ }
+ boolean splitBlockletWise;
+ try {
+ splitBlockletWise = Boolean.parseBoolean(splitBlockletStr);
+ } catch (NumberFormatException e) {
+ splitBlockletWise = false;
--- End diff --
I think it is better to make default as true, to make lucene index smaller
---
