Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2322#discussion_r189477789
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java
 ---
    @@ -191,7 +143,7 @@ private boolean 
isSameColumnSchemaList(List<ColumnSchema> indexFileColumnList,
           return detailedBlocklets;
         }
         Set<TableBlockIndexUniqueIdentifier> identifiers =
    -        getTableBlockIndexUniqueIdentifiers(segment);
    +        getTableBlockIndexUniqueIdentifiers(segment, 
this.getCarbonTable().getTableUniqueName());
    --- End diff --
    
    I think it is better to move getTableBlockIndexUniqueIdentifiers function 
to `CarbonTable`


---

Reply via email to