Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2252#discussion_r189911364
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/DimensionRawColumnChunk.java
---
@@ -92,8 +93,10 @@ public DimensionColumnPage decodeColumnPage(int
pageNumber) {
* @param index
* @return
*/
- public DimensionColumnPage convertToDimColDataChunkWithOutCache(int
index) {
+ public DimensionColumnPage convertToDimColDataChunkWithOutCache(int
index,
+ boolean isLongStringColumn) {
--- End diff --
why this is required???...as mentioned in earlier comment...reader does not
know which type of data it is reading
---
