Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2334#discussion_r190104064
  
    --- Diff: 
integration/presto/src/main/java/org/apache/carbondata/presto/PrestoFilterUtil.java
 ---
    @@ -110,28 +88,30 @@ else if 
(colType.equals(DecimalType.createDecimalType(carbondataColumnHandle.get
         for (ColumnHandle columnHandle : 
originalConstraint.getDomains().get().keySet()) {
           CarbondataColumnHandle carbondataColumnHandle = 
(CarbondataColumnHandle) columnHandle;
           List<ColumnSchema> partitionedColumnSchema = 
columnSchemas.stream().filter(
    -          columnSchema -> 
carbondataColumnHandle.getColumnName().equals(columnSchema.getColumnName())).collect(toList());
    -      if(partitionedColumnSchema.size() != 0) {
    +              columnSchema -> 
carbondataColumnHandle.getColumnName().equals(columnSchema.getColumnName())).collect(toList());
    +      if (partitionedColumnSchema.size() != 0) {
             filter.addAll(createPartitionFilters(originalConstraint, 
carbondataColumnHandle));
           }
         }
         return filter;
       }
     
    -  /** Returns list of partition key and values using domain constraints
    +  /**
    +   * Returns list of partition key and values using domain constraints
    +   *
        * @param originalConstraint
        * @param carbonDataColumnHandle
        */
       private static List<String> 
createPartitionFilters(TupleDomain<ColumnHandle> originalConstraint,
    -      CarbondataColumnHandle carbonDataColumnHandle) {
    +                                                     
CarbondataColumnHandle carbonDataColumnHandle) {
    --- End diff --
    
    Why change this one?


---

Reply via email to