Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2332#discussion_r190128821
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -2382,6 +2382,7 @@ static DataType thriftDataTyopeToWrapperDataType(
         CarbonIndexFileReader indexFileReader = new CarbonIndexFileReader();
         indexFileReader.openThriftReader(indexFilePath);
         org.apache.carbondata.format.IndexHeader readIndexHeader = 
indexFileReader.readIndexHeader();
    +    indexFileReader.closeThriftReader();
    --- End diff --
    
    Add a try finally block and move closing of thrift reader to finally block


---

Reply via email to