Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2335#discussion_r190446798
--- Diff:
datamap/mv/core/src/main/scala/org/apache/carbondata/mv/rewrite/MatchConditions.scala
---
@@ -1,28 +1,32 @@
/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
+ * Copyright (c) Huawei Futurewei Technologies, Inc. All Rights Reserved.
*
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
*/
package org.apache.carbondata.mv.rewrite
-// TODO: implement this to modularize DefaultMatchingFunctions
+//import org.apache.carbondata.mv.plans.modular.ModularPlan
+
+//TODO: implement this to modularize DefaultMatchingFunctions
object MatchConditions {
+// def setupMatchConditions(subsumer: SparkyPlan, subsumee: SparkyPlan,
compensation: SparkyPlan): MatchConditions = {
--- End diff --
Why not just remove them?
---
