[GitHub] carbondata pull request #2321: [CARBONDATA-2520] Clean and close datamap wri...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2321#discussion_r191149210
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/loading/AbstractDataLoadProcessorStep.java
 ---
    @@ -149,6 +153,22 @@ protected CarbonRowBatch 
processRowBatch(CarbonRowBatch rowBatch) {
        */
       protected abstract String getStepName();
     
    +  /**
    +   * This method registers all writer listeners and returns the listener
    +   * @param rangeId bucketId
    +   * @return
    +   */
    +  protected DataMapWriterListener getDataMapWriterListener(int rangeId) {
    --- End diff --
    
    remove the rangeId since it is always 0


---