Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2327#discussion_r191163607
--- Diff:
core/src/main/java/org/apache/carbondata/core/cache/CacheProvider.java ---
@@ -101,6 +102,31 @@ public static CacheProvider getInstance() {
return cacheTypeToCacheMap.get(cacheType);
}
+ /**
+ * This method will check if a cache already exists for given cache type
and store
+ * if it is not present in the map
+ */
+ public <K, V> Cache<K, V> createCache(CacheType cacheType, String
cacheClassName)
--- End diff --
It is not disadvantaged, we should give only one cache size to configure,
we cannot give different cache sizes for different features. It is difficult to
maintain and difficult for the user to estimate the memory he can allocate for
the cache. It is one of the main reason we want to bring all caches into single
configurable size.
---
