Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2290#discussion_r191447617
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java 
---
    @@ -96,13 +96,19 @@ private DataMapStoreManager() {
           String dbName = carbonTable.getDatabaseName();
           String tableName = carbonTable.getTableName();
           String dmName = dataMap.getDataMapSchema().getDataMapName();
    -      boolean isDmVisible = sessionInfo.getSessionParams().getProperty(
    -          String.format("%s%s.%s.%s", 
CarbonCommonConstants.CARBON_DATAMAP_VISIBLE,
    -              dbName, tableName, dmName), 
"true").trim().equalsIgnoreCase("true");
    -      if (!isDmVisible) {
    -        LOGGER.warn(String.format("Ignore invisible datamap %s on table 
%s.%s",
    -            dmName, dbName, tableName));
    -        dataMapIterator.remove();
    +      if (sessionInfo != null) {
    +        boolean isDmVisible = sessionInfo.getSessionParams().getProperty(
    +                String.format("%s%s.%s.%s", 
CarbonCommonConstants.CARBON_DATAMAP_VISIBLE,
    +                        dbName, tableName, dmName), 
"true").trim().equalsIgnoreCase("true");
    +        if (!isDmVisible) {
    +          LOGGER.warn(String.format("Ignore invisible datamap %s on table 
%s.%s",
    +                  dmName, dbName, tableName));
    +          dataMapIterator.remove();
    +        }
    +      } else {
    +        // TODO: need support get the visible status of datamp in the 
future
    +        String message = "Carbon session info is null";
    +        LOGGER.audit(message);
    --- End diff --
    
    ok,done


---

Reply via email to