Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2363#discussion_r194323660
  
    --- Diff: 
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
    @@ -105,6 +115,243 @@ public void testWriteAndReadFiles() throws 
IOException, InterruptedException {
         FileUtils.deleteDirectory(new File(path));
       }
     
    +  @Test
    +  public void testReadWithFilterOfTransactional() throws IOException, 
InterruptedException {
    --- End diff --
    
    All these code changes of this PR is for NonTransactional table.  I think 
test case for Transactional table is redundant. 


---

Reply via email to