Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2328#discussion_r195668205
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/carbondata/stream/StreamJobManager.scala
 ---
    @@ -0,0 +1,185 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.stream
    +
    +import java.util.concurrent.{ConcurrentHashMap, CountDownLatch, TimeUnit}
    +
    +import scala.collection.JavaConverters._
    +
    +import org.apache.spark.sql.{DataFrame, SparkSession}
    +import org.apache.spark.sql.streaming.StreamingQuery
    +import org.apache.spark.sql.types.{StructField, StructType}
    +
    +import org.apache.carbondata.common.exceptions.NoSuchStreamException
    +import 
org.apache.carbondata.common.exceptions.sql.MalformedCarbonCommandException
    +import org.apache.carbondata.common.logging.LogServiceFactory
    +import org.apache.carbondata.core.metadata.schema.table.CarbonTable
    +import org.apache.carbondata.spark.StreamingOption
    +import org.apache.carbondata.spark.util.CarbonScalaUtil
    +import org.apache.carbondata.streaming.CarbonStreamException
    +import org.apache.carbondata.streaming.parser.CarbonStreamParser
    +
    +object StreamJobManager {
    --- End diff --
    
    Add description to the class. And also better mention that this stream job 
is only available to the driver memory and not persisted so other drivers 
cannot see ongoing stream jobs.


---

Reply via email to