[GitHub] carbondata pull request #2374: [CARBONDATA-2613] Support csv based carbon ta...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2374#discussion_r197010299
  
    --- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java ---
    @@ -515,12 +573,72 @@ private CarbonInputSplit 
convertToCarbonInputSplit(ExtendedBlocklet blocklet) th
         return split;
       }
     
    +  private List<CarbonInputSplit> 
convertToInputSplit4ExternalFormat(JobContext jobContext,
    --- End diff --
    
    Why don't use CSVInputFormat.getSplits? I can see the code is almost 
similar as `FileInputFormat.getSplits`


---