Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2389#discussion_r197019345
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/carbondata/events/DataMapEvents.scala
 ---
    @@ -0,0 +1,76 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.events
    +
    +import org.apache.spark.sql.SparkSession
    +
    +import org.apache.carbondata.core.metadata.AbsoluteTableIdentifier
    +
    +/**
    + * For handling operation's after finish of index creation over table with 
index datamap
    + * example: bloom datamap, Lucene datamap
    + */
    +case class CreateDataMapPostExecutionEvent(sparkSession: SparkSession,
    +    storePath: String) extends Event with CreateDataMapEventsInfo
    +
    +/**
    + * For handling operation's before start of update index datmap status 
over table with index datamap
    + * example: bloom datamap, Lucene datamap
    + */
    +case class UpdateDataMapPreExecutionEvent(sparkSession: SparkSession,
    +    storePath: String) extends Event with CreateDataMapEventsInfo
    +
    +/**
    + * For handling operation's after finish of  update index datmap status 
over table with index
    + * datamap
    + * example: bloom datamap, Lucene datamap
    + */
    +case class UpdateDataMapPostExecutionEvent(sparkSession: SparkSession,
    +    storePath: String) extends Event with CreateDataMapEventsInfo
    +
    +/**
    + * For handling operation's before start of index build over table with 
index datamap
    + * example: bloom datamap, Lucene datamap
    + */
    +case class BuildDataMapPreExecutionEvent(sparkSession: SparkSession,
    +    identifier: AbsoluteTableIdentifier, dataMapNames: 
scala.collection.mutable.Seq[String])
    +  extends Event with BuildDataMapEventsInfo
    +
    +/**
    + * For handling operation's before start of index build during load over 
table with index datamap
    + * example: bloom datamap, Lucene datamap
    + */
    +case class LoadDataMapPreExecutionEvent(sparkSession: SparkSession,
    --- End diff --
    
    check if we can remove LoadDataMap event and instead use BuildDataMap events


---

Reply via email to