GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2400
[HOTFIX] Removed BatchedDataSourceScanExec class and extended directly from
FileSourceScanExec
Problem:
Since some of the code of BatchedDataSourceScanExec is copied from spark,
it is difficult to maintain from version upgrades of spark. Currently we face
issues during spark 2.3 upgrade so better remove it.
Solution:
Remove BatchedDataSourceScanExec and extend directly the spark class
FileSourceScanExec.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravipesala/incubator-carbondata
remove-batch-scan
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2400.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2400
----
commit 48dcaa2dec8eb914ef99be21dd3657feb1028368
Author: ravipesala <ravi.pesala@...>
Date: 2018-06-22T12:43:59Z
Removed BatchedDataSourceScanExec class and extended directly from
FileSourceScanExec
----
---
