[GitHub] carbondata pull request #2402: [CARBONDATA-2587][CARBONDATA-2588] Local Dict...

[akashrn5]

Github user akashrn5 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2402#discussion_r197604461
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java 
---
    @@ -104,19 +105,27 @@
             
page.setStatsCollector(KeyPageStatsCollector.newInstance(DataTypes.BYTE_ARRAY));
             dictDimensionPages[tmpNumDictDimIdx++] = page;
           } else {
    +        // will be encoded using string page
    +        LocalDictionaryGenerator localDictionaryGenerator =
    +            model.getColumnLocalDictGenMap().get(spec.getFieldName());
             if (DataTypes.VARCHAR == spec.getSchemaDataType()) {
    -          page = ColumnPage.newPage(spec, DataTypes.VARCHAR, pageSize);
    +          page = ColumnPage.newLocalDictPage(spec,
    --- End diff --
    
    if the `localDictionaryGenerator` is null, for VARCHAR also, it should not 
generate localDictPage, null check is missing i think


---