[GitHub] carbondata pull request #2396: [CARBONDATA-2606] [Complex DataType Enhanceme...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2396#discussion_r197724373
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedResultCollector.java
 ---
    @@ -102,6 +123,9 @@ public 
DictionaryBasedResultCollector(BlockExecutionInfo blockExecutionInfos) {
             dictionaryColumnIndex = 0;
             noDictionaryColumnIndex = 0;
             complexTypeColumnIndex = 0;
    +        mergedComplexDimensionDataMap = new HashMap<>();
    --- End diff --
    
    Why it is created for each row? why not reuse ?


---