Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2402#discussion_r197821950
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
---
@@ -110,44 +135,51 @@ public
CarbonFactDataWriterImplV3(CarbonFactDataHandlerModel model) {
*/
@Override public void writeTablePage(TablePage tablePage)
throws CarbonDataWriterException,IOException {
- // condition for writting all the pages
- if (!tablePage.isLastPage()) {
- boolean isAdded = false;
- // check if size more than blocklet size then write the page to file
- if (blockletDataHolder.getSize() +
tablePage.getEncodedTablePage().getEncodedSize() >=
- blockletSizeThreshold) {
- // if blocklet size exceeds threshold, write blocklet data
- if (blockletDataHolder.getEncodedTablePages().size() == 0) {
- isAdded = true;
- addPageData(tablePage);
- }
+ try {
--- End diff --
dnt format the code if code is not changed
---
