GitHub user ndwangsen opened a pull request:
https://github.com/apache/carbondata/pull/2414
[CARBONDATA-2658][DataLoad]No difference in memory spilled to disk for any
value of carbon.load.sortMemory.spill.percentage
the parameter carbon.load.sortMemory.spill.percentage configured the value
range 0-100,according to configuration merge and spill in-memory pages to disk
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
NA
- [ ] Any backward compatibility impacted?
NA
- [ ] Document update required?
NA
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
Test pass in environment
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ndwangsen/incubator-carbondata bugfix_09939
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2414.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2414
----
commit 736c571ce911374d8cde16f9d6f64b310984f5e9
Author: ndwangsen <luffy.wang@...>
Date: 2018-06-22T04:02:36Z
ADD carbon.load.sortMemory.spill.percentage parameter invalid value
check
commit 1671f3b114d229c81c4ea7b8023d80334e512df0
Author: ndwangsen <luffy.wang@...>
Date: 2018-06-25T06:24:56Z
Update CarbonLoadOptionConstants.java
add a space
commit a976783f6787ec1401389a3427820aa1b572a5dc
Author: ndwangsen <luffy.wang@...>
Date: 2018-06-26T12:19:22Z
the parameter carbon.load.sortMemory.spill.percentage configured the
value range 0-100,according to configuration merge and spill in-memory
pages to disk
----
---