GitHub user kumarvishal09 opened a pull request:

    https://github.com/apache/carbondata/pull/2427

    [WIP][CARBONDATA-2669] Local Dictionary Store Size optimisation and other 
function issues

    Problems:
    1. Local dictionary store size issue.
    When all column data is empty and columns are not present in sort columns 
local dictionary size was more than no dictionary dictionary store size.
    2. Page level dictionary merging Issue
    While merging the page used dictionary values in a blocklet it was missing 
some of the dictionary values, this is because, AND operation was done on bitset
    3. Local Dictionary null values
    Null value was not added in LV because of this new dictionary values was 
getting generated for null values
    
    Solution:
    1. Added rle for unsorted dictionary values.
    
    Added rle for unsorted dictionary data to reduce the size.
    
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests 
are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance 
test report.
            - Any additional information to help reviewers in testing this 
change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kumarvishal09/incubator-carbondata 
localdictdataloadingtests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2427.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2427
    
----
commit 1a17ea3b85b878808be8f30f7f08ed4ad8de48b8
Author: kumarvishal09 <kumarvishal1802@...>
Date:   2018-06-28T17:19:37Z

    Local dictionary issue fix

----


---

Reply via email to