Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2397#discussion_r199041131
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/merger/UnsafeIntermediateMerger.java
---
@@ -88,6 +88,10 @@ public UnsafeIntermediateMerger(SortParameters
parameters) {
CarbonLoadOptionConstants.CARBON_LOAD_SORT_MEMORY_SPILL_PERCENTAGE,
CarbonLoadOptionConstants.CARBON_LOAD_SORT_MEMORY_SPILL_PERCENTAGE_DEFAULT);
spillPercentage = Integer.valueOf(spillPercentageStr);
+ if (spillPercentage > 100 || spillPercentage < 0) {
--- End diff --
property validation can be validated in
`CarbonProperties.validateAndLoadDefaultProperties`, please add it there. And I
agree with @zzcclp , you can add a function in `CarbonProperties` to get the
value of this property, just like `getInsertIntoDatasetStorageLevel`
---
