[GitHub] carbondata pull request #2403: [CARBONDATA-2633][BloomDataMap] Fix bugs in b...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2403#discussion_r199325781
  
    --- Diff: 
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomDataMapWriter.java
 ---
    @@ -69,6 +86,27 @@
         indexBloomFilters = new ArrayList<>(indexColumns.size());
         initDataMapFile();
         resetBloomFilters();
    +
    +    keyGenerator = segmentProperties.getDimensionKeyGenerator();
    --- End diff --
    
    Can we optimize this instead of passing the whole `SegmentProperties` into 
this Writer class? Please check @ravipesala 


---