[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

[gvramana]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2417#discussion_r199482930
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingFactory.java
 ---
    @@ -161,14 +174,16 @@ private static DataType fitLongMinMax(long max, long 
min) {
       }
     
       private static DataType fitMinMax(DataType dataType, Object max, Object 
min) {
    -    if (dataType == DataTypes.BYTE) {
    +    if ((dataType == DataTypes.BYTE) || (dataType == DataTypes.BOOLEAN)) {
    --- End diff --
    
    Use Switch instead of ifelse


---