Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2432#discussion_r200019591
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
 ---
    @@ -106,6 +106,24 @@ case class PreAggregateTableHelper(
         tableProperties.put(CarbonCommonConstants.FLAT_FOLDER,
           
parentTable.getTableInfo.getFactTable.getTableProperties.asScala.getOrElse(
             CarbonCommonConstants.FLAT_FOLDER, 
CarbonCommonConstants.DEFAULT_FLAT_FOLDER))
    +
    +    // update column name with prefix for long_string_column
    --- End diff --
    
    Can you describe what is the prefix, and why it is needed in the comment


---

Reply via email to