[GitHub] carbondata pull request #2422: [CARBONDATA-2585][CARBONDATA-2586][Local Dict...

[praveenmeenakshi56]

Github user praveenmeenakshi56 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2422#discussion_r200237535
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
 ---
    @@ -391,7 +495,7 @@ object TableNewProcessor {
         if (dataType == DataTypes.DATE) {
           encoders.add(Encoding.DIRECT_DICTIONARY)
         }
    -    if (dataType == DataTypes.TIMESTAMP && ! 
highCardinalityDims.contains(colName)) {
    --- End diff --
    
    these are all handled in #2450


---