[GitHub] carbondata pull request #2451: [CARBONDATA-2585][CARBONDATA-2586]Fix local d...

[xuchuanyin]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2451#discussion_r200255313
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala
 ---
    @@ -116,14 +116,33 @@ case class PreAggregateTableHelper(
             parentTable.getTableInfo.getFactTable.getTableProperties.asScala
               .getOrElse(CarbonCommonConstants.LOCAL_DICTIONARY_THRESHOLD,
                 CarbonCommonConstants.LOCAL_DICTIONARY_THRESHOLD_DEFAULT))
    -    tableProperties
    -      .put(CarbonCommonConstants.LOCAL_DICTIONARY_INCLUDE,
    -        parentTable.getTableInfo.getFactTable.getTableProperties.asScala
    -          .getOrElse(CarbonCommonConstants.LOCAL_DICTIONARY_INCLUDE, ""))
    -    tableProperties
    -      .put(CarbonCommonConstants.LOCAL_DICTIONARY_EXCLUDE,
    -        parentTable.getTableInfo.getFactTable.getTableProperties.asScala
    -          .getOrElse(CarbonCommonConstants.LOCAL_DICTIONARY_EXCLUDE, ""))
    +    val parentdict_include = 
parentTable.getTableInfo.getFactTable.getTableProperties.asScala
    +      .getOrElse(CarbonCommonConstants.LOCAL_DICTIONARY_INCLUDE, 
"").split(",")
    +
    +    val parentdict_exclude = 
parentTable.getTableInfo.getFactTable.getTableProperties.asScala
    +      .getOrElse(CarbonCommonConstants.LOCAL_DICTIONARY_EXCLUDE, 
"").split(",")
    +
    +    var newdict_include = Seq[String]()
    +    var newdict_exclude = Seq[String]()
    +    parentdict_include.foreach(parentcol =>
    --- End diff --
    
    just use：
    val newDictInclude = XXXX.filter().map(_.column)


---