[GitHub] carbondata pull request #2417: [WIP][Complex Column Enhancements]Primitive D...

[dhatchayani]

Github user dhatchayani commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2417#discussion_r200307851
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -3177,4 +3177,34 @@ public static void 
setLocalDictColumnsToWrapperSchema(List<ColumnSchema> columns
         }
         return columnLocalDictGenMap;
       }
    +
    +  public static DataType getMappingDataType(String type) {
    --- End diff --
    
    Please reuse 
org.apache.carbondata.core.util.DataTypeUtil#valueOf(java.lang.String)  this 
method.. This seems to be duplicate method


---