Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2354#discussion_r200345615
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonDataMergerUtil.java
 ---
    @@ -1218,11 +1217,8 @@ public static boolean 
isHorizontalCompactionEnabled() {
           blockDetails.setDeleteDeltaEndTimestamp(timestamp.toString());
     
           try {
    -        if (startCompactionDeleteDeltaFiles(deleteFilePathList, blockName, 
fullBlockFilePath)) {
    -          blockDetails.setCompactionStatus(true);
    -        } else {
    -          blockDetails.setCompactionStatus(false);
    -        }
    +        startCompactionDeleteDeltaFiles(deleteFilePathList, blockName, 
fullBlockFilePath);
    --- End diff --
    
    make startCompactionDeleteDeltaFiles return type void


---

Reply via email to