Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2425#discussion_r200805465
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/datamap/IndexDataMapRebuildRDD.scala
---
@@ -144,13 +148,113 @@ class OriginalReadSupport(dataTypes:
Array[DataType]) extends CarbonReadSupport[
}
}
+/**
+ * This class will generate row value which is raw bytes for the
dimensions.
+ */
+class RawBytesReadSupport(segmentProperties: SegmentProperties,
indexColumns: Array[CarbonColumn])
--- End diff --
ehh, There is another ReadSupport called 'OriginalReadSupport' in this file
which is similar with this 'RawBytesReadSupport'. Do we need to move it too?
Besides, This class is only used IndexRebuildDmRDD, I think it's better to
keep them here.
---
