[GitHub] carbondata pull request #2436: [CARBONDATA-2682][32K] fix create table with ...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2436#discussion_r200897980
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
 ---
    @@ -486,6 +504,60 @@ abstract class CarbonDDLSqlParser extends 
AbstractCarbonSparkSQLParser {
         }
       }
     
    +  /**
    +   * This method validates the long string columns
    +   *
    +   * @param fields
    +   * @param varcharCols
    +   * @return
    +   */
    +  private def validateLongStringColumns(fields: Seq[Field],
    --- End diff --
    
    Why not put line 395 validation logic also in this func?


---