Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2463#discussion_r201586698
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
 ---
    @@ -588,6 +591,21 @@ object CarbonDataRDDFactory {
         }
       }
     
    +  /**
    +   * clear datamap files for segment
    +   */
    +  private def clearDataMapFiles(carbonTable: CarbonTable, segmentId: 
String): Unit = {
    +    try {
    +      DataMapStoreManager.getInstance().getAllDataMap(carbonTable).asScala
    +        .filter(_.getDataMapSchema.isIndexDataMap).foreach { p =>
    +        p.deleteDatamapData(List(new Segment(segmentId)).asJava)
    --- End diff --
    
    move `List(new Segment(segmentId)).asJava` before the loop and move 
`foreach` to next line, to make it better formatted


---

Reply via email to