Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2483#discussion_r202013849
  
    --- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/iud/DeleteCarbonTableTestCase.scala
 ---
    @@ -298,6 +298,43 @@ class DeleteCarbonTableTestCase extends QueryTest with 
BeforeAndAfterAll {
     
       }
     
    +  test("test to check if delete table is reflected in table with 
datamaps") {
    --- End diff --
    
    please split it into two testcase, one for index datamap, another for 
preaggregate datamap
    
    the title can be "block deleting records from table which has index 
datamap" and "block deleting records from table which has preaggregate datamap"


---

Reply via email to