Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2490#discussion_r202230753
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/AbstractBloomDataMapWriter.java
---
@@ -173,7 +173,13 @@ protected void addValue2BloomIndex(int indexColIdx,
Object value) {
} else {
if (indexColumns.get(indexColIdx).hasEncoding(Encoding.DICTIONARY)
||
indexColumns.get(indexColIdx).hasEncoding(Encoding.DIRECT_DICTIONARY)) {
- indexValue = convertDictionaryValue(indexColIdx, (byte[]) value);
+ if (value.getClass().isArray()) {
--- End diff --
Maybe we can add a variable to indicate whether it is from
'Rebuild(builder0' or 'DirectWrite(writer)'. Use the class type as condition is
not proper.
Do not forget to add comments for that variable.
---
