[GitHub] carbondata pull request #2487: [CARBONDATA-2735]Fixed Performance issue for ...

[gvramana]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2487#discussion_r202319613
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/SafeVarLengthColumnPage.java
 ---
    @@ -40,6 +40,7 @@
       @Override
       public void freeMemory() {
         byteArrayData = null;
    +    rowOffset.freeMemory();
    --- End diff --
    
    rowOffset.freeMemory also required in SafeDecimalColumnPage.
    It will we good practice to call rowOffset.freeMemory  in same class it is 
allocated, call abstract freememory class from derived to ensure any clean up 
from abstract class


---