[GitHub] carbondata pull request #2503: [CARBONDATA-2734] Update is not working on th...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2503#discussion_r202508061
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/DeleteExecution.scala
 ---
    @@ -134,7 +134,7 @@ object DeleteExecution {
                            groupedRows.toIterator,
                            timestamp,
                            rowCountDetailsVO,
    -                       carbonTable.isHivePartitionTable)
    +                       segmentFile)
    --- End diff --
    
    Is it better to pass SegmentStatus instead of string, to have better 
encapsulation 


---