[GitHub] carbondata pull request #2475: [CARBONDATA-2531][MV] Fix alias not working o...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2475#discussion_r202544362
  
    --- Diff: 
datamap/mv/core/src/main/scala/org/apache/carbondata/mv/rewrite/DefaultMatchMaker.scala
 ---
    @@ -367,8 +367,10 @@ object GroupbyGroupbyNoChildDelta extends 
DefaultMatchPattern {
             if (isGroupingEmR && isGroupingRmE) {
               val isOutputEmR = gb_2q.outputList.forall {
                 case a @ Alias(_, _) =>
    -              gb_2a.outputList.exists{a1 =>
    -                a1.isInstanceOf[Alias] && 
a1.asInstanceOf[Alias].child.semanticEquals(a.child)
    +              gb_2a.outputList.exists{
    +                case a1: Alias =>
    +                a1.child.semanticEquals(a.child)
    --- End diff --
    
    Is this indentation correct? 


---