GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2537
[CARBONDATA-2768][CarbonStore] Fix error in tests for external csv format
In previous implementation earlier than PR2495, we only supportted csv as
external format for carbondata. And we validated the restriction while
creating the table.PR2495 added kafka support, so it removed the
validation, but it did not fix the related test case which cause failure in
current version.
This PR fix the error test case.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`NO`
- [x] Any backward compatibility impacted?
`NO`
- [x] Document update required?
`NO`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
`Tests updated`
- How it is tested? Please attach test report.
`Tested in local`
- Is it a performance related change? Please attach the performance
test report.
`NO`
- Any additional information to help reviewers in testing this
change.
`NA`
- [x] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
`NA`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata 0723_fix_tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2537.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2537
----
commit a1ce8a15f1d3b2a1b4173137694a064cd7c04cb5
Author: xuchuanyin <xuchuanyin@...>
Date: 2018-07-23T03:09:54Z
Fix error in tests for external csv format
In previous implementation earlier than PR2495, we only supportted csv as
external format for carbondata. And we validated the restriction while
creating the table.PR2495 added kafka support, so it removed the
validation, but it did not fix the related test case which cause
test failure in current version.
This PR fix the error test case.
----
---
